Only aggregate selected columns #2278
Open
+21,634
−9,112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [v3.4.19] - 2024-09-08 ### Bug Fixes - Adjustment for Laravel 10 GH Workflows by @lrljoe in rappasoft#1933 - Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. by @lrljoe in rappasoft#1932 - Add button type to tailwind pagination blade template by @matzeschmitt in rappasoft#1928
* Revert tableName to be public (rappasoft#1937) * v3.4.20 ChangeLog --------- Co-authored-by: lrljoe <[email protected]>
* Migration to Core attribute management * Fix styling * Fix missing type hint, update tests * Fix styling * Remove defaults from being output * Fix styling * Adjust defaults * Adjust behaviour for Bulk Actions TH * Add "styling" to Columns docs * Docs Adjust, add missing test * Fix styling * Adjust workflows - use L11 for PHPStan, use PHPUnit for L10 * Add missing test for thSortIconAttributes * Fix styling * Add CustomAttributesTest * Fix styling * Add missing tests - correct attribute to respect defaults * Fix styling * Remove defined processes in workflows * Add test for setShouldBeHidden and setShouldBeDisplayed * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Merging Localisation Tweaks * Fix styling * Tweak localisations * Fix styling * Tweaks to sorting pill direction label * Fix styling * Fixes for Sorting Pill Labels --------- Co-authored-by: lrljoe <[email protected]>
* Fix for Search Field Attribute Defaults * SearchFieldAttributes -> Defaults To False
…Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (rappasoft#1963)
* Update Pint Workflow * Update ChangeLog * Test Styling Workflow * Fix styling * Test Workflow * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add explanation of setRefreshMethod (rappasoft#1857) * Unlocking Entangled Items (rappasoft#1859) * Unlock properties locked in error --------- Co-authored-by: lrljoe <[email protected]> * Add dispatch on updated filter components (rappasoft#1861) * Add additional dispatch * Add FilterApplied Event * Add Filter Event Dispatch Tests --------- Co-authored-by: lrljoe <[email protected]> * v3.4.8 * Fix superfluous bulk actions tr < (rappasoft#1868) * Default useComputedProperties to False (rappasoft#1869) * Update ChangeLog * Add Action Buttons (rappasoft#1864) * Make ActionButtons An Optional Feature in Beta --------- Co-authored-by: lrljoe <[email protected]> * FixDateRangeFilter (rappasoft#1872) * Adjust Methods - useComputedProperties (rappasoft#1873) * Adjust Methods - useComputedProperties * Adjust ActionTest * Update ChangeLog * AllowDeleteDateRangeFilter (rappasoft#1875) * Fix ChangeLog * Update Docs (rappasoft#1876) * Update ChangeLog - Add Docs Update * Add setIconLeft/setIconRight (rappasoft#1877) * Add setIconLeft/setIconRight * Fix styling * Adjust Test * Adjust ActionTest --------- Co-authored-by: lrljoe <[email protected]> * Adjust ChangeLog * Adjust Action Button Icon Margin (rappasoft#1880) * Adjust Action Button Icon Margin * Adjust ChangeLog * Change Order of "Getting Started" section (rappasoft#1883) * Change Order of "Getting Started" section * Change to "UsersTable" * Add Button with No Icon (rappasoft#1887) * Add a "Recommended" approach (rappasoft#1886) * Add a "Recommended" approach * Add blurb to Recommended * v3.4.13 * Set actions position (rappasoft#1889) * Add displayActionsInToolbar and actionsPosition * Add docs and tests for setActionsInToolbar * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Doc Type Fixes (rappasoft#1891) * Update NumberFilter and TypeHints * Update DateFilter/DateTimeFilter and ConfigurableAreasHelpers for typehints and array key exists * Add Float Test for NumberFilter * Add ColorColumn View Test * Adjust ColumnSelectConfigurationTest --------- Co-authored-by: lrljoe <[email protected]> * BooleanColumn - Toggleable Callback (rappasoft#1892) * Add Docs, Code for Toggleable Columns * Add Confirmation Option * Tweak Blade - Standardise * Add Tests for Toggleable --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Enable/Disable Tools/Toolbar (rappasoft#1896) * Customised Toolbar Approach --------- Co-authored-by: lrljoe <[email protected]> * Use Computed Properties By Default (rappasoft#1898) * Fix has actions (rappasoft#1901) * Fix Action Repetitive Calling * Fix validActionsCount --------- Co-authored-by: lrljoe <[email protected]> * Add icon column (rappasoft#1902) * Initial Commit - Awaiting Docs & Tests * Tweak to IconColumn label behaviour * Adding IconColumn documentation * Add Additional Tests - Replace Test Database * Add Visuals Test for IconColumn * Add Icon Columns to Other Column Types * Undo FrontendAssetsTest Changes --------- Co-authored-by: lrljoe <[email protected]> * Add Baseline - Convert phpstan.neon to tabs (rappasoft#1903) * Update ChangeLog * Save filter selection to session (BETA) (rappasoft#1910) * Initial Commit * Fix styling * Initial Commit * Fix styling * Fix nullable return * Add Initial Tests - Remove Non-Required Method * Fix styling * Swap methods * Add default docs * Remove errant note * Adjust docs * Adjust Docs for storeFiltersInSessionEnabled --------- Co-authored-by: lrljoe <[email protected]> * Add hide table option (rappasoft#1914) * Initial Commit * Fix styling * Further adjustments * Fix styling * Improve Tests - Extend PetsTable * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add column select session methods (rappasoft#1913) * Initial Commit * Fix styling * Minor Tweaks * Fix styling * Fix Tests * Add Tests for StoredColumnSelect * Fix styling * Add Missing Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Use Core HasTheme Methods (rappasoft#1915) * Centralise Theme Methods * Fix styling * Fix for broken tests * Fix styling * Remove persisted computed properties --------- Co-authored-by: lrljoe <[email protected]> * Use Core Attribute Bag (rappasoft#1916) * Initial Commit * Fix styling * Add Missing Test * Fix styling * Adjustments * Fix styling * Adjust Test * Fix styling * Fix Sorting Visual Test --------- Co-authored-by: lrljoe <[email protected]> * Fix ChangeLog * Add Polish translation by @meavric (rappasoft#1925) * Add Polish translation by @meavric * Update ChangeLog to reflect translation * Add Vertical Scrolling Example (rappasoft#1926) * Adjusting contributing * Fix missing variable in workflow (rappasoft#1933) * Fix missing variable name * Remove phpunit failOnWarning * Tests * PCOV Use Laravel 11 * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. (rappasoft#1932) * Initial Commit - Allowing Labels with "From" to be included in queries * Fix styling * Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. --------- Co-authored-by: lrljoe <[email protected]> * Add button type to tailwind pagination blade template (rappasoft#1928) * v3.4.19 ChangeLog * Revert tableName to be public (rappasoft#1937) * v3.4.20 ChangeLog * Migration to Core attribute management (rappasoft#1943) * Migration to Core attribute management * Fix styling * Fix missing type hint, update tests * Fix styling * Remove defaults from being output * Fix styling * Adjust defaults * Adjust behaviour for Bulk Actions TH * Add "styling" to Columns docs * Docs Adjust, add missing test * Fix styling * Adjust workflows - use L11 for PHPStan, use PHPUnit for L10 * Add missing test for thSortIconAttributes * Fix styling * Add CustomAttributesTest * Fix styling * Add missing tests - correct attribute to respect defaults * Fix styling * Remove defined processes in workflows * Add test for setShouldBeHidden and setShouldBeDisplayed * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update docs - add Action setLabelAttributes method (rappasoft#1952) * Reset Page on "Per Page" changing (rappasoft#1953) * Localisation - Avoid Conflicts With Other Packages (rappasoft#1955) * Merging Localisation Tweaks * Fix styling * Tweak localisations * Fix styling * Tweaks to sorting pill direction label * Fix styling * Fixes for Sorting Pill Labels --------- Co-authored-by: lrljoe <[email protected]> * Add filterComponents into queryString (rappasoft#1957) * Fix syntax for DateColumn outputFormat in docs (rappasoft#1960) * Fix Filter Pills Icon - Tailwind (rappasoft#1961) * Add original translation strings - for use in published views (rappasoft#1959) * Fix for Search Field Attribute Defaults (rappasoft#1962) * Fix for Search Field Attribute Defaults * SearchFieldAttributes -> Defaults To False * Change the type of LaravelLivewireTablesEvent::$user from Illuminate\Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (rappasoft#1963) * Remove persist from getFilterGenericData (rappasoft#1966) * Update ChangeLog * Update Pint Workflow (rappasoft#1967) * Update Pint Workflow * Update ChangeLog * Test Styling Workflow * Fix styling * Test Workflow * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update Discord Releases Workflow (rappasoft#1968) * Update ChangeLog --------- Co-authored-by: lrljoe <[email protected]> Co-authored-by: Matthias Schmitt <[email protected]> Co-authored-by: Paoulo Riveros <[email protected]>
* FixLoadingPlaceholderBug * Adjust tests for new Loading blade
* Update for v12 support * Add L12 Tests * Fix for PHPStan Run * update phpstan ignores * Restore larastan 2.x for pre-11
## [v3.7.0] - 2025-02-27 ### Bug Fixes - Filters urgent fixes - correct Filter Default QueryString by @lrljoe in rappasoft#2188 - Fix Search Field in bootstrap by @yparitcher in rappasoft#2183 - Add "after-tools" configurable area by @lrljoe in rappasoft#2180 ### New Features - Add setFilterPillTitleAsHtml by @lrljoe in rappasoft#2204 - Enable setting styles for sorting pills as a configuration by @HussamAlhennawi in rappasoft#2179 - Enable setting styles for filter pills as a configuration by @HussamAlhennawi in rappasoft#2178 - Enable setting styles for column select as a configuration by @HussamAlhennawi in rappasoft#2175 - BulkActionTweaks - Adding default checkbox, customising attribute behaviours by @lrljoe in rappasoft#2203 - Laravel v12 Support by @lrljoe in rappasoft#2217 ### Tweaks - Tweak for text pill title by @lrljoe in rappasoft#2206 - Tweak Return Types by @lrljoe in rappasoft#2205 - Migrate Column/Filter Traits by @lrljoe in rappasoft#2202 - Filter Rationalisation & Livewire Array Filter improvements by @lrljoe in rappasoft#2191 - Move Filter View Traits by @lrljoe in rappasoft#2189 - Filter Trait - Reorganization by @lrljoe in rappasoft#2181
* Add handling for From field for "LinkColumn" * Fix styling
* Add handling for From field for "LinkColumn" * Fix styling
* Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog
Co-authored-by: Joe <[email protected]>
* Link column fix (rappasoft#2223) (rappasoft#2224) * Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Update IsNumericFilter.php Fixes issues 2229 --------- Co-authored-by: Joe <[email protected]>
* Add BooleanFilter option for Bootstrap * Add BS4 Support * Update docs
* Initial Commit * Fix styling * Initial Commit * Fix styling * Adjust test * Fix styling * Use test-livewire-column-component * Additional Tests for LivewireComponentColumn * Fix styling * Add getContents Test
* Fix broken typehints * Minor tweaks to Footer/SecondaryHeader to ensure presence of callback prior to executing * Fix styling * PHPDoc additions * Fix styling * Update ChangeLog for TypeHintFixes * Fix styling * FilterPillData and StandardFilterPillData phpdocs * Fix styling
* Add Wrapper Options to FlexCol * Fix styling * Moving getContents Back * Fix styling * Add Docs * Add Wrapper Manual Tests * Fix styling * Update to test separator * Fix styling
* Link column fix (rappasoft#2223) (rappasoft#2224) * Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Improved pagination UX --------- Co-authored-by: Joe <[email protected]>
* Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Fix styling * Update ChangeLog * docs: add reminder of requirement to use toggle method (rappasoft#2208) Co-authored-by: Joe <[email protected]> * Update IsNumericFilter.php (rappasoft#2230) * Link column fix (rappasoft#2223) (rappasoft#2224) * Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Update IsNumericFilter.php Fixes issues 2229 --------- Co-authored-by: Joe <[email protected]> * Fix styling * Boolean filter for bootstrap (rappasoft#2244) * Add BooleanFilter option for Bootstrap * Add BS4 Support * Update docs * Fixes for livewire component column (rappasoft#2245) * Initial Commit * Fix styling * Initial Commit * Fix styling * Adjust test * Fix styling * Use test-livewire-column-component * Additional Tests for LivewireComponentColumn * Fix styling * Add getContents Test * TypeHint/PHPDoc Tidying (rappasoft#2246) * Fix broken typehints * Minor tweaks to Footer/SecondaryHeader to ensure presence of callback prior to executing * Fix styling * PHPDoc additions * Fix styling * Update ChangeLog for TypeHintFixes * Fix styling * FilterPillData and StandardFilterPillData phpdocs * Fix styling * Add Wrapper Options to ArrayColumn (rappasoft#2255) * Add Wrapper Options to FlexCol * Fix styling * Moving getContents Back * Fix styling * Add Docs * Add Wrapper Manual Tests * Fix styling * Update to test separator * Fix styling * Improved pagination UX (rappasoft#2251) * Link column fix (rappasoft#2223) (rappasoft#2224) * Link column fix (rappasoft#2223) * Add handling for From field for "LinkColumn" * Update ChangeLog * Improved pagination UX --------- Co-authored-by: Joe <[email protected]> * Fixed collapsed function bug with tailwind CSS on mobile version (rappasoft#2228) * v3.7.2 updates (rappasoft#2256) --------- Co-authored-by: da-mask <[email protected]> Co-authored-by: G4Zz0L1 <[email protected]> Co-authored-by: Daniel Škopek <[email protected]> Co-authored-by: CarlosChub27 <[email protected]>
* Tweak Livewire Component Column Key Behaviour * Update Changelog
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Description
Aggregation can complicate the query quite a bit and significantly slows down the query.
I would have like it if only "usefull" aggregate columns where calculated.
I understand that filters and sort could be applied even on invisible columns so this would break current behaviour.
A global setting to enable and disable this behaviour could be preferable and i don't know how "hiddenColumn" should interract with this.
In my case the potential performance gains justify this feature usefullness but i let you be the juge on this matter.
This change is small enough that i didn't feel the need to add test or documentation changes.
Let me know if they are required and if other matters should be taken into concideration.
Thank you for your time